fix: set defaultTag to INPUT_FLAGD_VERSION (#332)

Signed-off-by: Skye Gill <gill.skye95@gmail.com>
open-feature · Jan 31, 2023 · 23547a1 · 23547a1
1 parent 67976be
commit 23547a1
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 22 deletions.
diff --git a/Makefile b/Makefile
@@ -89,7 +89,7 @@ run: manifests generate fmt vet ## Run a controller from your host.
 	go run ./main.go
 
 .PHONY: docker-build
-docker-build:  ## Build docker image with the manager.
+docker-build: update-flagd  ## Build docker image with the manager.
 	docker buildx build --platform="linux/amd64,linux/arm64" -t ${IMG} . --push
 
 .PHONY: docker-push

diff --git a/apis/core/v1alpha1/flagsourceconfiguration_types.go b/apis/core/v1alpha1/flagsourceconfiguration_types.go
@@ -29,27 +29,28 @@ import (
 type SyncProviderType string
 
 const (
-	SidecarEnvVarPrefix              string           = "SIDECAR_ENV_VAR_PREFIX"
-	SidecarMetricPortEnvVar          string           = "METRICS_PORT"
-	SidecarPortEnvVar                string           = "PORT"
-	SidecarSocketPathEnvVar          string           = "SOCKET_PATH"
-	SidecarEvaluatorEnvVar           string           = "EVALUATOR"
-	SidecarImageEnvVar               string           = "IMAGE"
-	SidecarVersionEnvVar             string           = "TAG"
-	SidecarProviderArgsEnvVar        string           = "PROVIDER_ARGS"
-	SidecarDefaultSyncProviderEnvVar string           = "SYNC_PROVIDER"
-	defaultSidecarEnvVarPrefix       string           = "FLAGD"
-	InputConfigurationEnvVarPrefix   string           = "SIDECAR"
-	defaultMetricPort                int32            = 8014
-	defaultPort                      int32            = 8013
-	defaultSocketPath                string           = ""
-	defaultEvaluator                 string           = "json"
-	defaultImage                     string           = "ghcr.io/open-feature/flagd"
-	defaultTag                       string           = "INPUT_FLAGD_VERSION"
-	SyncProviderKubernetes           SyncProviderType = "kubernetes"
-	SyncProviderFilepath             SyncProviderType = "filepath"
-	SyncProviderHttp                 SyncProviderType = "http"
-	defaultSyncProvider                               = SyncProviderKubernetes
+	SidecarEnvVarPrefix              string = "SIDECAR_ENV_VAR_PREFIX"
+	SidecarMetricPortEnvVar          string = "METRICS_PORT"
+	SidecarPortEnvVar                string = "PORT"
+	SidecarSocketPathEnvVar          string = "SOCKET_PATH"
+	SidecarEvaluatorEnvVar           string = "EVALUATOR"
+	SidecarImageEnvVar               string = "IMAGE"
+	SidecarVersionEnvVar             string = "TAG"
+	SidecarProviderArgsEnvVar        string = "PROVIDER_ARGS"
+	SidecarDefaultSyncProviderEnvVar string = "SYNC_PROVIDER"
+	defaultSidecarEnvVarPrefix       string = "FLAGD"
+	InputConfigurationEnvVarPrefix   string = "SIDECAR"
+	defaultMetricPort                int32  = 8014
+	defaultPort                      int32  = 8013
+	defaultSocketPath                string = ""
+	defaultEvaluator                 string = "json"
+	defaultImage                     string = "ghcr.io/open-feature/flagd"
+	// `INPUT_FLAGD_VERSION` is replaced in the `update-flagd` Makefile target
+	defaultTag             string           = "INPUT_FLAGD_VERSION"
+	SyncProviderKubernetes SyncProviderType = "kubernetes"
+	SyncProviderFilepath   SyncProviderType = "filepath"
+	SyncProviderHttp       SyncProviderType = "http"
+	defaultSyncProvider                     = SyncProviderKubernetes
 )
 
 // EDIT THIS FILE!  THIS IS SCAFFOLDING FOR YOU TO OWN!