Skip to content

Commit

Permalink
chore: Remove metrics-port flag/usage from flagdproxy startup (#587)
Browse files Browse the repository at this point in the history
Signed-off-by: Erik Westra <e.s.westra.95@gmail.com>
  • Loading branch information
webstradev authored Dec 19, 2023
1 parent 5a7b2c6 commit f79c46f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions common/flagdproxy/flagdproxy.go
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ func (f *FlagdProxyHandler) newFlagdProxyManifest(ownerReferences []metav1.Owner
replicas := int32(1)
args := []string{
"start",
"--metrics-port",
"--management-port",
fmt.Sprintf("%d", f.config.ManagementPort),
}
if f.config.DebugLogging {
Expand Down Expand Up @@ -165,7 +165,7 @@ func (f *FlagdProxyHandler) newFlagdProxyManifest(ownerReferences []metav1.Owner
ContainerPort: int32(f.config.Port),
},
{
Name: "metrics-port",
Name: "management-port",
ContainerPort: int32(f.config.ManagementPort),
},
},
Expand Down
4 changes: 2 additions & 2 deletions common/flagdproxy/flagdproxy_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ func TestFlagdProxyHandler_HandleFlagdProxy_CreateProxy(t *testing.T) {
replicas := int32(1)
args := []string{
"start",
"--metrics-port",
"--management-port",
fmt.Sprintf("%d", 90),
"--debug",
}
Expand Down Expand Up @@ -256,7 +256,7 @@ func TestFlagdProxyHandler_HandleFlagdProxy_CreateProxy(t *testing.T) {
ContainerPort: int32(88),
},
{
Name: "metrics-port",
Name: "management-port",
ContainerPort: int32(90),
},
},
Expand Down

0 comments on commit f79c46f

Please sign in to comment.