fix: mount dirs not files #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Todd Baert <toddbaert@gmail.com>
Signed-off-by: Todd Baert <toddbaert@gmail.com>
toddbaert
requested review from
AlexsJones,
beeme1mr and
skyerus
as code owners
Signed-off-by: Todd Baert <toddbaert@gmail.com>
Signed-off-by: Todd Baert <toddbaert@gmail.com>
beeme1mr
approved these changes
Jan 28, 2023
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #326 +/- ##
==========================================
+ Coverage 60.84% 61.06% +0.22%
==========================================
Files 4 4
Lines 521 524 +3
==========================================
+ Hits 317 320 +3
Misses 184 184
Partials 20 20
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This was referenced Jan 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to mount dirs, not files. For this reason, our previous solution to handle multiple configmaps didn't work (events weren't being seen in flagd in k8s).
This change mounts each ff/configmap in it's own unique dir, preserving all events and allowing multiples.