chore: Remove metrics-port flag/usage from flagdproxy startup #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddbaert
reviewed
Dec 18, 2023
webstradev
force-pushed
the
remove-deprecated-metrics-port
branch
2 times, most recently
from
0de8dfa
to
01be2a4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #587 +/- ##
=======================================
Coverage 87.98% 87.98%
=======================================
Files 10 10
Lines 932 932
=======================================
Hits 820 820
Misses 89 89
Partials 23 23
Flags with carried forward coverage won't be shown. Click here to find out more. |
toddbaert
approved these changes
Dec 19, 2023
Signed-off-by: Erik Westra <e.s.westra.95@gmail.com>
toddbaert
force-pushed
the
remove-deprecated-metrics-port
branch
from
01be2a4
to
e9d8241
Compare
beeme1mr
approved these changes
Dec 19, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
This flag was deprecated and is now removed from flagd so it needs to be removed here before using the new version of flagd.
Related Issues
Closes #586
Notes
Follow-up Tasks
How to test