feat: introduce configurable resource limits for flagd sidecar #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
It would be great to leverage some benchmark metrics to help define reasonable default resource limits. There's an open issue in the flagd repo requesting this information. |
skyerus
force-pushed
the
issue-222_flagd-resource-limits
branch
from
f0016ba
to
f37f682
Compare
skyerus
commented
Dec 6, 2022
Codecov Report
@@ Coverage Diff @@
## main #241 +/- ##
==========================================
+ Coverage 50.46% 50.90% +0.43%
==========================================
Files 3 3
Lines 432 444 +12
==========================================
+ Hits 218 226 +8
- Misses 199 202 +3
- Partials 15 16 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Kavindu-Dodan
approved these changes
Dec 7, 2022
|
@skyerus is this ready to be reviewed? |
It will be after open-feature/flagd#225 has hit main (need to include links to the benchmarks) |
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
skyerus
force-pushed
the
issue-222_flagd-resource-limits
branch
from
8f8cc2f
to
5d924a7
Compare
toddbaert
approved these changes
Dec 13, 2022
james-milligan
approved these changes
Dec 16, 2022
AlexsJones
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
Notes
Follow-up Tasks
How to test