-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce configurable resource limits for flagd sidecar #241
feat: introduce configurable resource limits for flagd sidecar #241
Conversation
It would be great to leverage some benchmark metrics to help define reasonable default resource limits. There's an open issue in the flagd repo requesting this information. |
f0016ba
to
f37f682
Compare
Codecov Report
@@ Coverage Diff @@
## main #241 +/- ##
==========================================
+ Coverage 50.46% 50.90% +0.43%
==========================================
Files 3 3
Lines 432 444 +12
==========================================
+ Hits 218 226 +8
- Misses 199 202 +3
- Partials 15 16 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@skyerus is this ready to be reviewed? |
It will be after open-feature/flagd#225 has hit main (need to include links to the benchmarks) |
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
8f8cc2f
to
5d924a7
Compare
This PR
Related Issues
Notes
Follow-up Tasks
How to test