-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Decouple feature flag spec from flagd config #276
Conversation
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Ill expand the test suite once everyone is happy with the approach |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generated charts need to be removed (i can't comment on the file)
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to include a .DT_Store
? Apparently you're on a Mac 😄
caught using |
Signed-off-by: James Milligan <james@omnant.co.uk>
Codecov Report
@@ Coverage Diff @@
## main #276 +/- ##
==========================================
- Coverage 50.90% 50.82% -0.08%
==========================================
Files 3 4 +1
Lines 444 486 +42
==========================================
+ Hits 226 247 +21
- Misses 202 221 +19
- Partials 16 18 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Converting to draft until I return from my Christmas break! 🎅 |
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: James Milligan <75740990+james-milligan@users.noreply.github.com>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Hey @toddbaert @AlexsJones, any concerns about this PR? It would be great to get this merged so @james-milligan can add support for these settings in Helm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @toddbaert @AlexsJones, any concerns about this PR? It would be great to get this merged so @james-milligan can #271.
@beeme1mr My only concern was this which is resolved now. Approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
This PR
flagDConfig
field of theFeatureflagConfiguration
crdFlagSourceConfiguration
to handle the configopenfeature.dev/flagsourceconfiguration
and associated documentationRelated Issues
#274
Notes
Follow-up Tasks
How to test