-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: role binding backfill #295
feat: role binding backfill #295
Conversation
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
@james-milligan I could be missing something, but I still seem to have the issue after an upgrade. Here are the steps I took:
Then I applied the fix:
Maybe I've somehow tested this fix incorrectly? If so please let me know what I did wrong. |
As discussed on on slack, the root cause of my issue was that I was using the old invalid annotation As you noted, we may want to add support for the deprecated annotation too. But otherwise, this works as expected. Nice job! |
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Ive added in support for the |
Signed-off-by: James Milligan <james@omnant.co.uk>
Codecov Report
@@ Coverage Diff @@
## main #295 +/- ##
==========================================
+ Coverage 50.90% 51.60% +0.70%
==========================================
Files 3 3
Lines 444 498 +54
==========================================
+ Hits 226 257 +31
- Misses 202 222 +20
- Partials 16 19 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
resolved test race condition through introducing a 'complete' channel to the |
This PR
Related Issues
#292
Notes
Follow-up Tasks
This PR expands one of the options for resolving the bug described in the issue above. On startup a grouroutine is started with a 5 second timeout (to allow cache to be ready), and all pods with the
openfeature.dev/enabled
annotation set to"true"
will have their service accounts added to theflagd-kubernetes-sync
role binding, restoring its state to that which it was prior to the upgrade.How to test
Upgrade helm and verify that the flagd connection is reestablished.