Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add instruction for using OFO and GitOps #497

Merged
merged 7 commits into from
Jul 21, 2023

Conversation

thisthat
Copy link
Member

This PR

adds some notes on a shortcoming of the compatibility of OFO with Applications deployed via GitOps.

Argo example

While deploying an App that makes use of FF via Argo, flagD was continuously failing with the following error log:

error   kubernetes/kubernetes_sync.go:115   error with the initial fetch: featureflagconfigurations.core.openfeature.dev "featureflagconfiguration-sample" is forbidden: User "system:serviceaccount:myawesomeapp:default" cannot get resource "featureflagconfigurations" in API group "core.openfeature.dev" in the namespace

After some debugging, we discovered that Argo was changing back the RoleBinding deployed with the Application.
We fixed the issue by adding the following info to the Argo App so it doesn't try to reconcile the Role Bindings changed by OFO:

ignoreDifferences:
  - group: "rbac.authorization.k8s.io"
    kind: "ClusterRoleBinding"
    jsonPointers:
    - /subjects  
...
syncOptions:
  - RespectIgnoreDifferences=true

@thisthat thisthat requested a review from a team as a code owner July 10, 2023 12:06
@toddbaert
Copy link
Member

I think this only impacts the kubernetes sync, but after looking through the doc, I don't think we do a great job describing the files/kubernetes/flagd-proxy syncs. I think the best place to put this would be in a section talking about the kubernetes sync.

How would you feel about adding this to @Kavindu-Dodan 's improved doc here: https://github.com/open-feature/open-feature-operator/pull/496/files#diff-c282aa25f1dabaaba19197006c4aa6bab00e8d2b2100375c42b41b7cf4bc55cbR14 ?

@thisthat
Copy link
Member Author

@toddbaert sure thing! I'll wait until that PR is merged and then build on top of that 👍

@thisthat thisthat marked this pull request as draft July 10, 2023 12:57
@toddbaert
Copy link
Member

Great. Nice find BTW!

docs/installation.md Outdated Show resolved Hide resolved
Signed-off-by: Giovanni Liva <giovanni.liva@dynatrace.com>
Signed-off-by: Giovanni Liva <giovanni.liva@dynatrace.com>
Signed-off-by: Giovanni Liva <giovanni.liva@dynatrace.com>
Signed-off-by: Giovanni Liva <giovanni.liva@dynatrace.com>
@thisthat thisthat marked this pull request as ready for review July 11, 2023 08:42
@thisthat
Copy link
Member Author

@toddbaert @Kavindu-Dodan @beeme1mr the PR is ready for review.

docs/concepts.md Outdated Show resolved Hide resolved
docs/concepts.md Outdated Show resolved Hide resolved
docs/concepts.md Outdated Show resolved Hide resolved
docs/concepts.md Outdated Show resolved Hide resolved
Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left optional suggestions.

I think this is pretty much perfect, great addition.

thisthat and others added 2 commits July 12, 2023 08:12
Signed-off-by: Giovanni Liva <giovanni.liva@dynatrace.com>
Co-authored-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Giovanni Liva <giovanni.liva@dynatrace.com>
@toddbaert toddbaert requested a review from beeme1mr July 12, 2023 12:31
@toddbaert
Copy link
Member

@beeme1mr any concerns with merging this now?

@thisthat
Copy link
Member Author

@beeme1mr ping

@beeme1mr beeme1mr merged commit 244a625 into open-feature:main Jul 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants