-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add instruction for using OFO and GitOps #497
Conversation
I think this only impacts the How would you feel about adding this to @Kavindu-Dodan 's improved doc here: https://github.com/open-feature/open-feature-operator/pull/496/files#diff-c282aa25f1dabaaba19197006c4aa6bab00e8d2b2100375c42b41b7cf4bc55cbR14 ? |
@toddbaert sure thing! I'll wait until that PR is merged and then build on top of that 👍 |
Great. Nice find BTW! |
Signed-off-by: Giovanni Liva <giovanni.liva@dynatrace.com>
Signed-off-by: Giovanni Liva <giovanni.liva@dynatrace.com>
Signed-off-by: Giovanni Liva <giovanni.liva@dynatrace.com>
612d824
to
8915443
Compare
@toddbaert @Kavindu-Dodan @beeme1mr the PR is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left optional suggestions.
I think this is pretty much perfect, great addition.
Signed-off-by: Giovanni Liva <giovanni.liva@dynatrace.com>
Co-authored-by: Todd Baert <todd.baert@dynatrace.com> Signed-off-by: Giovanni Liva <giovanni.liva@dynatrace.com>
@beeme1mr any concerns with merging this now? |
@beeme1mr ping |
This PR
adds some notes on a shortcoming of the compatibility of OFO with Applications deployed via GitOps.
Argo example
While deploying an App that makes use of FF via Argo, flagD was continuously failing with the following error log:
After some debugging, we discovered that Argo was changing back the RoleBinding deployed with the Application.
We fixed the issue by adding the following info to the Argo App so it doesn't try to reconcile the Role Bindings changed by OFO: