-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use webhook ns if empty, more test versions #568
Conversation
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #568 +/- ##
==========================================
+ Coverage 87.90% 87.98% +0.07%
==========================================
Files 10 10
Lines 926 932 +6
==========================================
+ Hits 814 820 +6
Misses 89 89
Partials 23 23
Flags with carried forward coverage won't be shown. Click here to find out more. |
If we're going to maintain code to support older versions, why not just test older versions as well so we actually see when we break them? |
We could update the matrix to |
They run in parallel: https://github.com/open-feature/open-feature-operator/actions/runs/7061357527/job/19222819640?pr=569 |
Signed-off-by: Todd Baert <toddbaert@gmail.com>
This PR
Reintroduces using admission webhook namespace if pod namespace is empty
Related Issues
Fixes #500
Notes
This was accidentally removed during a recent refactor. It wasn't caught in our tests because the oldest version that's tested is
1.25
. I've added a comment above the change to make it clear why this logic is there.