feat: new GO Feature Flag PHP provider #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
thomaspoignant
force-pushed
the
goff-php-provider
branch
2 times, most recently
from
6218ede
to
380c997
Compare
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
thomaspoignant
force-pushed
the
goff-php-provider
branch
from
380c997
to
aaa2577
Compare
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
|
This is largely up to you, but it would be convenient for consumers of the SDKs to be able to utilize the PHP HTTP discovery package to automatically provide a PSR compliant implementation based on their packages. This is in no way something I would expect before merging a 0.1.0 version. I know that there are still some tests to fix, but let me know if there is any more I can help with @thomaspoignant 👋 |
thomaspoignant
force-pushed
the
goff-php-provider
branch
from
48b1ede
to
6fe9c17
Compare
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
thomaspoignant
force-pushed
the
goff-php-provider
branch
from
6fe9c17
to
542e9ec
Compare
|
Hey @tcarrio, thanks for your input about the HTTP Client. This version is now ready to be reviewed, I'll be happy to have your feedback. |
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
This was referenced Aug 12, 2024
beeme1mr
approved these changes
Sep 3, 2024
This was referenced Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Resolve thomaspoignant/go-feature-flag#1714