Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include targetingKey in flagd serialized evaluation context #58

Merged
merged 1 commit into from
Feb 24, 2024

Conversation

federicobond
Copy link
Member

See https://flagd.dev/reference/specifications/rpc-providers/#serialization-of-the-evaluation-context

No tests were added this time but this functionality should be covered with tests against a real flagd server.

@federicobond federicobond requested a review from a team as a code owner February 23, 2024 21:36
Signed-off-by: Federico Bond <federicobond@gmail.com>
@federicobond federicobond force-pushed the flagd/add-targetingkey branch from 0066604 to af1b3fa Compare February 23, 2024 21:36
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.60%. Comparing base (d8e10c7) to head (af1b3fa).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
+ Coverage   90.55%   90.60%   +0.05%     
==========================================
  Files           8        8              
  Lines         180      181       +1     
==========================================
+ Hits          163      164       +1     
  Misses         17       17              
Flag Coverage Δ
unittests 90.60% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@federicobond federicobond merged commit ddd79a4 into open-feature:main Feb 24, 2024
17 checks passed
@federicobond federicobond deleted the flagd/add-targetingkey branch February 24, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants