Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect timeout setting in grpc method calls #60

Merged
merged 1 commit into from
Feb 24, 2024

Conversation

federicobond
Copy link
Member

No description provided.

@federicobond federicobond requested a review from a team as a code owner February 23, 2024 22:26
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 92.02%. Comparing base (d8e10c7) to head (f7285f0).
Report is 13 commits behind head on main.

Files Patch % Lines
...src/openfeature/contrib/provider/flagd/provider.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
+ Coverage   90.55%   92.02%   +1.46%     
==========================================
  Files           8        8              
  Lines         180      188       +8     
==========================================
+ Hits          163      173      +10     
+ Misses         17       15       -2     
Flag Coverage Δ
unittests 92.02% <83.33%> (+1.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Federico Bond <federicobond@gmail.com>
@federicobond federicobond merged commit 0149cf7 into open-feature:main Feb 24, 2024
16 of 17 checks passed
@federicobond federicobond deleted the flagd/timeout branch February 24, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants