Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace scheme with tls argument in FlagdProvider constructor #61

Merged
merged 1 commit into from
Feb 24, 2024

Conversation

federicobond
Copy link
Member

@federicobond federicobond commented Feb 24, 2024

Replace schema parameter which was a leftover from the previous HTTP-based implementation.

The tls parameter now matches what the rest of the provider implementations are using, and maps better to the standard FLAGD_TLS environment variable (not implemented yet).

Note: this is technically a breaking change, but I'd venture that no users would currently be affected.

@federicobond federicobond requested a review from a team as a code owner February 24, 2024 01:42
Copy link

codecov bot commented Feb 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.02%. Comparing base (d8e10c7) to head (36ed53e).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
+ Coverage   90.55%   92.02%   +1.46%     
==========================================
  Files           8        8              
  Lines         180      188       +8     
==========================================
+ Hits          163      173      +10     
+ Misses         17       15       -2     
Flag Coverage Δ
unittests 92.02% <100.00%> (+1.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Federico Bond <federicobond@gmail.com>
@federicobond federicobond merged commit 7a7210f into open-feature:main Feb 24, 2024
19 checks passed
@federicobond federicobond deleted the flagd/tls branch February 27, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants