Merge pull request #14 from mschoenlaub/spec-0.4.0

Remove EvaluationOptions from method signatures
open-feature · Oct 7, 2022 · 1727554 · 1727554
2 parents 0f004af + 059ef20
commit 1727554
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 14 deletions.
diff --git a/open_feature/open_feature_client.py b/open_feature/open_feature_client.py
@@ -210,7 +210,6 @@ def evaluate_flag_details(
                 key,
                 default_value,
                 merged_context,
-                flag_evaluation_options,
             )
 
             after_hooks(type, hook_context, flag_evaluation, merged_hooks, None)
@@ -237,7 +236,6 @@ def create_provider_evaluation(
         key: str,
         default_value: typing.Any,
         evaluation_context: EvaluationContext = None,
-        flag_evaluation_options: typing.Any = None,
     ) -> FlagEvaluationDetails:
         """
         Encapsulated method to create a FlagEvaluationDetail from a specific provider.
@@ -246,15 +244,13 @@ def create_provider_evaluation(
         :param key: the string key of the selected flag
         :param default_value: backup value returned if no result found by the provider
         :param evaluation_context: Information for the purposes of flag evaluation
-        :param flag_evaluation_options: Additional flag evaluation information
         :return: a FlagEvaluationDetails object with the fully evaluated flag from a
         provider
         """
         args = (
             key,
             default_value,
             evaluation_context,
-            flag_evaluation_options,
         )
 
         if not self.provider:

diff --git a/open_feature/provider/no_op_provider.py b/open_feature/provider/no_op_provider.py
@@ -1,4 +1,3 @@
-import typing
 from numbers import Number
 
 from open_feature.evaluation_context.evaluation_context import EvaluationContext
@@ -18,7 +17,6 @@ def get_boolean_details(
         key: str,
         default_value: bool,
         evaluation_context: EvaluationContext = None,
-        flag_evaluation_options: typing.Any = None,
     ):
         return FlagEvaluationDetails(
             key=key,
@@ -32,7 +30,6 @@ def get_string_details(
         key: str,
         default_value: str,
         evaluation_context: EvaluationContext = None,
-        flag_evaluation_options: typing.Any = None,
     ):
         return FlagEvaluationDetails(
             key=key,
@@ -46,7 +43,6 @@ def get_number_details(
         key: str,
         default_value: Number,
         evaluation_context: EvaluationContext = None,
-        flag_evaluation_options: typing.Any = None,
     ):
         return FlagEvaluationDetails(
             key=key,
@@ -60,7 +56,6 @@ def get_object_details(
         key: str,
         default_value: dict,
         evaluation_context: EvaluationContext = None,
-        flag_evaluation_options: typing.Any = None,
     ):
         return FlagEvaluationDetails(
             key=key,

diff --git a/open_feature/provider/provider.py b/open_feature/provider/provider.py
@@ -1,4 +1,3 @@
-import typing
 from abc import abstractmethod
 from numbers import Number
 
@@ -16,7 +15,6 @@ def get_boolean_details(
         key: str,
         default_value: bool,
         evaluation_context: EvaluationContext = EvaluationContext(),
-        flag_evaluation_options: typing.Any = None,
     ):
         pass
 
@@ -26,7 +24,6 @@ def get_string_details(
         key: str,
         default_value: str,
         evaluation_context: EvaluationContext = EvaluationContext(),
-        flag_evaluation_options: typing.Any = None,
     ):
         pass
 
@@ -36,7 +33,6 @@ def get_number_details(
         key: str,
         default_value: Number,
         evaluation_context: EvaluationContext = EvaluationContext(),
-        flag_evaluation_options: typing.Any = None,
     ):
         pass
 
@@ -46,6 +42,5 @@ def get_object_details(
         key: str,
         default_value: dict,
         evaluation_context: EvaluationContext = EvaluationContext(),
-        flag_evaluation_options: typing.Any = None,
     ):
         pass