Add docker file for dependencies #66
Conversation
|
To run this container, run |
|
Metashape version is up to 2.1.3 and that's what we're using for new ofo dev VMs through CACAO (oh actually 2.1.2 currently but I should update it). Are you intentionally using v2.1.1 for the docker image? |
|
Nope, sorry, just copied from Jeff's image. I'll update it. Also, can I try to follow the same steps you did for the toy workflow to set up the github container registry? |
|
Awesome. Yes please do! I believe you'll just need the same github action (possibly tweaked depending on how you want the image tagged), and potentially one repo-level setting to enable packages (I can't remember). |
russelldj
force-pushed
the
feature/DR/add-docker-file
branch
from
6b7c8b8 to
2d286be
Compare
russelldj
changed the title
|
I think this is good to go. The only change I made to the actual |
|
While running a new dataset I got a |
| def parse_args(): | ||
| parser = argparse.ArgumentParser() | ||
| parser.add_argument("config_file", default=manual_config_file) | ||
|
|
||
| args = parser.parse_args() | ||
| return args | ||
|
|
||
| args = parse_args() |
There was a problem hiding this comment.
This is smart and much nicer. Thanks!
| ``` | ||
| docker run -v </host/data/dir>:/data -e AGISOFT_FLS=$AGISOFT_FLS --gpus all ghcr.io/open-forest-observatory/automate-metashape | ||
| ``` | ||
| Note that the owner of the output data will be the `root` user. To set the ownership to your user account, you can run `sudo chown <username>:<username> <file name>` or `sudo chown <username>:<username> -R <folder name>`. |
There was a problem hiding this comment.
I would add above this line (or elsewhere if you find a better spot):
If running Docker on Linux without
sudo(as in this example), your user will need to be in thedockergroup. This can be achieved withsudo usermod -a -G docker $USERand then logging out and in, as explained here.
There was a problem hiding this comment.
I added it to the top since it feels like another docker setup step.
|
@youngdjn I think this should address all your feedback. I'm just trying to figure make sure I have the |
|
The syntax seemed a little wonky but it follows the example from geograypher here. I think this is ready to merge. |
This is a step toward running containerized workflows. This file seems to work, but Metashape is not activated. For internal use, I expect that there is a way to set it up to communicate with the license server, but I'm not sure what that involves. @youngdjn, any thoughts?