📌 Pin lxml to not use binary wheels

This is in preparation to upgrading python3-saml and then lxml to their latest versions. lxml breaks on some edge cases becaues it was statically built against a different libxml2 than *other* xml-based tooling using at runtime ( because that's dynamically linked), causing some tree lookups to fail. * python3-saml issue: SAML-Toolkits/python3-saml#292 * upstream bug: https://bugs.launchpad.net/lxml/+bug/1960668
open-formulieren · Oct 26, 2022 · 0dabe18 · 0dabe18
1 parent b0bfb36
commit 0dabe18
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 0 deletions.
diff --git a/requirements/base.in b/requirements/base.in
@@ -6,6 +6,10 @@ furl
 glom
 git+https://github.com/maykinmedia/json-logic-py.git@f877f5326231bdcf4621783278f22c8565ec7913#egg=maykin-json-logic-py
 html5lib
+# see https://github.com/onelogin/python3-saml/issues/292 and
+# https://bugs.launchpad.net/lxml/+bug/1960668 -> we can avoid this by compiling lxml
+# against the system libxml2
+--no-binary lxml
 lxml
 O365  # microsoft graph
 phonenumbers

diff --git a/requirements/base.txt b/requirements/base.txt
@@ -4,6 +4,8 @@
 #
 #    ./bin/compile_dependencies.sh
 #
+--no-binary lxml
+
 amqp==5.0.9
     # via kombu
 asgiref==3.5.0

diff --git a/requirements/ci.txt b/requirements/ci.txt
@@ -4,6 +4,8 @@
 #
 #    ./bin/compile_dependencies.sh
 #
+--no-binary lxml
+
 alabaster==0.7.12
     # via sphinx
 amqp==5.0.9

diff --git a/requirements/dev.txt b/requirements/dev.txt
@@ -4,6 +4,8 @@
 #
 #    ./bin/compile_dependencies.sh
 #
+--no-binary lxml
+
 alabaster==0.7.12
     # via
     #   -c requirements/ci.txt