Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #3218

Merged
merged 3 commits into from
Jul 5, 2023
Merged

Conversation

sergei-maertens
Copy link
Member

@sergei-maertens sergei-maertens commented Jul 4, 2023

Related to #3049

  • Upgrades django-yubin (major version)
  • Upgrades django-axes (major version)

Breaking changes have been incorporated

@sergei-maertens sergei-maertens force-pushed the chore/3049-upgrade-dependencies branch from 73d764d to 468d86e Compare July 5, 2023 07:12
@sergei-maertens sergei-maertens mentioned this pull request Jul 4, 2023
43 tasks
@sergei-maertens sergei-maertens force-pushed the chore/3049-upgrade-dependencies branch from 468d86e to 83ee500 Compare July 5, 2023 07:18
django-yubin now uses celery for queuing out of the box, so we no longer
need to simulate cron to actually send out the e-mails.

See https://django-yubin.readthedocs.io/en/latest/install.html\#upgrading-from-previous-versions
which documents the upgrade steps.
@sergei-maertens sergei-maertens force-pushed the chore/3049-upgrade-dependencies branch from 83ee500 to 73ea9d7 Compare July 5, 2023 08:26
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch coverage: 80.00% and no project coverage change.

Comparison is base (b1c03be) 94.86% compared to head (73ea9d7) 94.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3218   +/-   ##
=======================================
  Coverage   94.86%   94.86%           
=======================================
  Files         622      622           
  Lines       19617    19606   -11     
  Branches     2219     2219           
=======================================
- Hits        18609    18600    -9     
+ Misses        718      716    -2     
  Partials      290      290           
Impacted Files Coverage Δ
...rc/openforms/registrations/contrib/email/checks.py 62.50% <0.00%> (ø)
src/openforms/utils/tasks.py 66.66% <ø> (+1.96%) ⬆️
src/openforms/conf/base.py 90.82% <100.00%> (-0.08%) ⬇️
src/openforms/emails/admin.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sergei-maertens sergei-maertens marked this pull request as ready for review July 5, 2023 08:50
@sergei-maertens sergei-maertens merged commit 625a474 into master Jul 5, 2023
@sergei-maertens sergei-maertens deleted the chore/3049-upgrade-dependencies branch July 5, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant