debug-log: add helpful hint msg about previous log_dir #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 14, 2018 18:26
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Logs on new log file path look like: 2018-12-14 18:30:31.154 14398 [CRIT] create_file_output:480: log file path now is '/var/log/gluster-block/tcmu-runner.log' 2018-12-14 18:30:31.154 14398 [CRIT] tcmu_resetup_log_file:748: you may find previous logs at '/var/log/tcmu-runner.log' Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
pkalever
force-pushed
the
helpful_msg
branch
from
9de601a
to
a7f89f3
Compare
| @@ -714,13 +714,17 @@ static bool is_same_path(const char* path1, const char* path2) | |||
| int tcmu_resetup_log_file(char *log_dir) | |||
| { | |||
| int ret; | |||
| char old_logdir[PATH_MAX] = {'\0', }; | |||
There was a problem hiding this comment.
I think tcmu_log_dir_set should have been called by the tcmu_log_dir_create caller and not tcmu_log_dir_create. tcmu_log_dir_create just creates the dirs. Calling it in tcmu_log_dir_create leads to the weird dance we do below and also if the resetup fails we were leaving it set to the bad value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logs on new log file path look like:
2018-12-14 18:30:31.154 14398 [CRIT] create_file_output:480:
log file path now is '/var/log/gluster-block/tcmu-runner.log'
2018-12-14 18:30:31.154 14398 [CRIT] tcmu_resetup_log_file:748:
you may find previous logs at '/var/log/tcmu-runner.log'
Signed-off-by: Prasanna Kumar Kalever prasanna.kalever@redhat.com