azblk handler version 1 #540
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The azure page blob handler is based on and serves as a user-space alternative to khenidak's dysk kernel block driver (https://github.com/khenidak/dysk). An azblk target device will be exposed to the local host as a TCMU scsi device via the target loopback driver (targetcli loopback transport). azblk currently supports SAS access credentials, lease ids, local read only permissions, http, and https. Each azblk target device must be configured through a configuration file whose default location is /etc/tcmu/azblk.conf. Sample config file: device = ( { name = "azblk1_http"; sas = "sp=rcwd&st=2019-02-22T15:00:55Z&se=2019-03-22T22:00:55Z&spr=https,http&sv=2018-03-28&sig=anIkHRlkadfjlkajdQVqIvENpLO9FL1zyQ%3D&sr=b"; lease = "48e29061-079d-446c-833c-5d884ab5ec1e"; url = "http://myazureaccount.blob.core.windows.net/test/test1.vhd"; }, { name = "azblk2_https"; sas = "sp=rcwd&st=2019-03-07T13:43:02Z&se=2019-04-04T20:43:02Z&spr=https,http&sv=2018-03-28&sig=MW3SK5h99alskdfjlkjnvV3xz%2BLLcAhDVI%3D&sr=b"; readonly = 1; url = "https://myazureaccount.blob.core.windows.net/test/test2.vhd"; } ); Signed-off-by: Cathy Avery <cavery@redhat.com>
lxbsz
reviewed
Mar 23, 2019
| @@ -0,0 +1,1006 @@ | |||
| /* | |||
| * Copyright (c) 2018 Red Hat, Inc. | |||
| * | |||
| curl_socket_t sockfd; | ||
| struct azblk_dev *ddev; | ||
| }; | ||
|
|
There was a problem hiding this comment.
There has one extra white line :-)
|
|
||
| return data_size; | ||
| } | ||
|
|
| AZ_SAS_LEN); | ||
| goto error; | ||
| } | ||
| strncpy(ddev->cfg.sas, sas, len); |
There was a problem hiding this comment.
Here we'd better to use the strlcpy as Mike has introduce it from BSD locally.
https://github.com/open-iscsi/tcmu-runner/blob/master/strlcpy.c
| case CURLMSG_DONE: | ||
| azblk_multi_done(curl_multi, message); | ||
| break; | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The azure page blob handler is based on and serves as a user-space
alternative to khenidak's dysk kernel block driver
(https://github.com/khenidak/dysk).
An azblk target device will be exposed to the local host as a TCMU scsi
device via the target loopback driver (targetcli loopback transport).
azblk currently supports SAS access credentials, lease ids,
local read only permissions, http, and https.
Each azblk target device must be configured through a configuration
file whose default location is /etc/tcmu/azblk.conf.
Sample config file:
device =
(
{
name = "azblk1_http";
sas = "sp=rcwd&st=2019-02-22T15:00:55Z&se=2019-03-22T22:00:55Z&spr=https,http&sv=2018-03-28&sig=anIkHRlkadfjlkajdQVqIvENpLO9FL1zyQ%3D&sr=b";
lease = "48e29061-079d-446c-833c-5d884ab5ec1e";
url = "http://myazureaccount.blob.core.windows.net/test/test1.vhd";
},
{
name = "azblk2_https";
sas = "sp=rcwd&st=2019-03-07T13:43:02Z&se=2019-04-04T20:43:02Z&spr=https,http&sv=2018-03-28&sig=MW3SK5h99alskdfjlkjnvV3xz%2BLLcAhDVI%3D&sr=b";
readonly = 1;
url = "https://myazureaccount.blob.core.windows.net/test/test2.vhd";
}
);
Signed-off-by: Cathy Avery cavery@redhat.com