Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add travis-integration for build verification #542

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pkalever
Copy link
Contributor

The docker build only does build and no testing added at this point.
We can start adding some tests soon.

Signed-off-by: Prasanna Kumar Kalever prasanna.kalever@redhat.com

@pkalever
Copy link
Contributor Author

@mikechristie @lxbsz

We are noticing, build issues with:
#539
#541

For future proof, lets have this travis-integration for build verifications.

travis docker build will be performed on every single PR after merging this changes both on centos7 and fedora29.

@mikechristie
Copy link
Collaborator

Looks nice. I am not familiar with setting it up. Besides your patch I also need to enable it on the repo right? Something like described here:

https://github.com/mbonaci/mbo-storm/wiki/Integrate-Travis-CI-with-your-GitHub-repo

or I can do directly here:

https://github.com/marketplace/travis-ci/plan/MDIyOk1hcmtldHBsYWNlTGlzdGluZ1BsYW43MA==#pricing-and-setup

@@ -0,0 +1,41 @@
# Dockerfile for testing the build of gluster-block based on centos7
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fix up the comment since you made it more generic. Same with the other file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, it was unintentional. I have copied the template from gluster-block repo. Fixed it now.

Thanks!

@lxbsz
Copy link
Collaborator

lxbsz commented Mar 26, 2019

@pkalever
Cool, this looks nice.

@mikechristie
Yeah, you need to enable travis-cli in the repo.

https://github.com/marketplace/travis-ci/plan/MDIyOk1hcmtldHBsYWNlTGlzdGluZ1BsYW43MA==#pricing-and-setup
This should.

Thanks.

The docker build only does build and no testing added at this point.
We can start adding some tests soon.

Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
@pkalever
Copy link
Contributor Author

@mikechristie right, you need to enable travis on the repo,

section:
https://github.com/mbonaci/mbo-storm/wiki/Integrate-Travis-CI-with-your-GitHub-repo#integrate-your-github-project-with-travis-ci

Should help turning travis ON.

Thanks!

@mikechristie
Copy link
Collaborator

Just some heads up. I am leaving on PTO and was not able to finish this before I left. I will handle when I get back on April 8th.

@pkalever
Copy link
Contributor Author

pkalever commented Mar 29, 2019

Just some heads up. I am leaving on PTO and was not able to finish this before I left. I will handle when I get back on April 8th.

Sure, no problem Mike!
Have a good time.

@lxbsz lxbsz changed the base branch from master to main August 10, 2022 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants