myAchievements: achievement link validation(fixes #8114)

[Mutugiii]

Fixes #8114

Link validation for an achievement under the myAchievements

[RheuX]

I think its working well (for non http examples), but I did test out some edges case, something like this

It will allow it even though all of these are invalid links

[Mutugiii]

@RheuX I've tackled the specific edge cases you mentioned, feel free to test again or even handle more edge cases

[jessewashburn]

It seems that anything after https:// or http:// (as long as it's not blank) is allowed.

[RheuX]

the edge case I mentioned is now blocked which is great,

i know we can't block every link that invalid, but probably another one is to check if at least have a common tld (https://tld-list.com/). so things like the one jesse mentioned shouldn't be possible. If they passed all the basic link validation, but just not a valid link (doesn't link to anywhere at the end), than thats something that we probably shouldn't handle unless you want to do a DNS Lookup

So TL;DR, I think we should implemented a regex that handle (i gave example to test out for the regex - they should be invalid)

• no spaces (http://examp le.com)
• only 1 period (http://example..com)
• should contain a common tld at the end (http://123httpexample)

this should be good enough for a basic validation link @Mutugiii

[jessewashburn]

I pushed some additional edge case handling with a regex. All the cases I mentioned plus support for multipart TLDs like .co.uk should now be handled appropriately.

updates pushed