Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Permissions on TestSuite and TestCases #19072

Merged
merged 33 commits into from
Feb 5, 2025
Merged

User Permissions on TestSuite and TestCases #19072

merged 33 commits into from
Feb 5, 2025

Conversation

harshach
Copy link
Collaborator

@harshach harshach commented Dec 14, 2024

Describe your changes:

Fixes #11002
Fixes #17948

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

TeddyCr
TeddyCr previously approved these changes Dec 16, 2024
IceS2
IceS2 previously approved these changes Dec 17, 2024
@@ -724,7 +725,8 @@ public Response delete(
@Parameter(description = "FQN of the logical test suite", schema = @Schema(type = "String"))
@PathParam("name")
String name) {
OperationContext operationContext = new OperationContext(entityType, MetadataOperation.DELETE);
OperationContext operationContext =
new OperationContext(Entity.TEST_SUITE, MetadataOperation.DELETE);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't entityType be the same as Entity.TEST_SUITE?

TeddyCr
TeddyCr previously approved these changes Jan 14, 2025
Copy link
Contributor

@TeddyCr TeddyCr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aniketkatkar97
aniketkatkar97 previously approved these changes Jan 31, 2025
aniketkatkar97
aniketkatkar97 previously approved these changes Jan 31, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

Copy link

sonarqubecloud bot commented Feb 5, 2025

Copy link

sonarqubecloud bot commented Feb 5, 2025

@TeddyCr TeddyCr merged commit be27f3e into main Feb 5, 2025
22 of 27 checks passed
@TeddyCr TeddyCr deleted the issue-11002-v1 branch February 5, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
5 participants