Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feed pagination improvement #19183

Merged
merged 1 commit into from
Dec 28, 2024
Merged

Feed pagination improvement #19183

merged 1 commit into from
Dec 28, 2024

Conversation

sonika-shah
Copy link
Contributor

@sonika-shah sonika-shah commented Dec 27, 2024

Describe your changes:

For activity feed, we use updatedAt field as cursor to support pagination. There are possible cases when multiple threads can have the same value of updatedAt, this results in feed results getting affected and not showing the correct result of threads where duplicate value is present, and in some cases throwing exception.

To avoid this behaviour we have used two fields (updatedAt,id) to always get unique value of cursor for comparison.
Note - id is of type uuid, so ordering in case of same timestamps will not be in lexicographic order , but we will always get all the threads , and there will be no case of missing thread

Before :

Screen.Recording.2024-12-27.at.1.14.42.PM.mov

After :

Screen.Recording.2024-12-27.at.1.05.45.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Copy link

@harshach harshach merged commit 633cead into main Dec 28, 2024
18 of 39 checks passed
@harshach harshach deleted the feed-pagination-improvement branch December 28, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants