Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
For activity feed, we use
updatedAt
field as cursor to support pagination. There are possible cases when multiple threads can have the same value of updatedAt, this results in feed results getting affected and not showing the correct result of threads where duplicate value is present, and in some cases throwing exception.To avoid this behaviour we have used
two fields (updatedAt,id)
to always get unique value of cursor for comparison.Note
- id is of type uuid, so ordering in case of same timestamps will not be in lexicographic order , but we will always get all the threads , and there will be no case of missing threadBefore :
Screen.Recording.2024-12-27.at.1.14.42.PM.mov
After :
Screen.Recording.2024-12-27.at.1.05.45.PM.mov
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>