Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: Use interface schemas for governance workflows #19411

Merged
merged 11 commits into from
Jan 24, 2025
Merged

MINOR: Use interface schemas for governance workflows #19411

merged 11 commits into from
Jan 24, 2025

Conversation

sushi30
Copy link
Contributor

@sushi30 sushi30 commented Jan 16, 2025 •
edited
Loading

Describe your changes:

  • Use explicit interface types in governance workflows
  • introduce placeholder for python workflow node
  • Introduce NoOp task
  • simplified trigger type names
  • removed governance workflow root "type"
  • added "deployed" field to governance workflow
  • applied changes to existing gov-workflows
  • migrations

Requires

#19338

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@sushi30
feat(apps): support event subscriptions
194c967 
- added support for apps with event subscriptions.
- added support for custom consumers on event subscriptions.
- use native application methods instead of reflection in ApplicationHandler
@sushi30
removed runMethodFromApplication reflection and use concrete methods …
787a367 
…from AbstractNativeApplication
@sushi30
format
567ae6d
@sushi30
fix(governance-workflows): defined interface in workflow schema
e9771bd 
- defined types for workflow nodes
- fixed updateEdge method in WorkflowDefinitionRepository
@sushi30
Merge branch 'workflow-governance-types' into app-on-config-change-event
dc0ea8a
@sushi30
ref(governance-workflows): use explicit types in schema
f749de1 
use explicit interface type in json schemas and use annotations to infer the concrete classes when deserializing
@sushi30 sushi30 requested review from a team as code owners January 16, 2025 13:03
@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Jan 16, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 16, 2025 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.65% (40875/63221) 40.89% (16420/40153) 44.11% (4969/11266)

@sushi30
- implemented CustomSignal trigger
b8fcea3 
- use JsonTypeInfo and JsonSubTypes to infer types in jsonschema for nodes and triggers
- Implemented JsonLogicFilter task
- implemented placeholder noop task
@github-actions GitHub Actions
Copy link
Contributor

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@sushi30
- simplified trigger type names
1a9030d 
- removed governance workflow root "type"
- added "deployed" field to governance workflow
- applied changes to existing gov-workflows
- migrations
@sushi30 sushi30 changed the title MINOR: Streamline governange workflows json schemas MINOR: Use interface schemas for governance workflows Jan 21, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sushi30 sushi30 enabled auto-merge (squash) January 23, 2025 14:49
@sushi30 sushi30 merged commit a6670af into main Jan 24, 2025
24 of 28 checks passed
@sushi30 sushi30 deleted the streamline-governange-workflows branch January 24, 2025 08:08
sonika-shah added a commit that referenced this pull request Jan 24, 2025
@sonika-shah
Fix postgres query added in pr #19411
a7b22c3
@sonika-shah sonika-shah mentioned this pull request Jan 24, 2025
Merged
9 tasks
sonika-shah added a commit that referenced this pull request Jan 24, 2025
@sonika-shah
Fix postgres query added in pr #19411 (#19512)
3267b71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 approved these changes

@IceS2 IceS2 IceS2 approved these changes

Assignees
No one assigned
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sushi30 @IceS2 @ShaileshParmar11