Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 19499: feat(apps): add app config in run record #19544

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Fix 19499: feat(apps): add app config in run record #19544

wants to merge 9 commits into from
+268 −67

Conversation

sushi30
Copy link
Contributor

@sushi30 sushi30 commented Jan 27, 2025 •
edited by karanh37
Loading

  • changed returned schema type of "status" to "AppRunRecord"!
  • added a "config" field in the app record
  • added a "pending" stage so that "external" app status can be mapped ti internal app status

TODO

  • retrieve configuration for internal apps

delivers #19499

Describe your changes:

Enable retrieval of app configuration for a specific run.

Old runs might not be compatible with schema of app configuration.

Screenshot 2025-01-27 at 17 00 28

Implementation

Screen.Recording.2025-01-29.at.9.02.15.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@sushi30
feat(apps): add app config in run record
c337b0a 
- changed returned schema type of "status" to "AppRunRecord"!
- added a "config" field in the app record
- added a "pending" stage so that "external" app status can be mapped ti internal app status
@sushi30 sushi30 requested review from a team as code owners January 27, 2025 16:11
@sushi30 sushi30 changed the title feat(apps): add app config in run record Fix 19499: feat(apps): add app config in run record Jan 27, 2025
@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Jan 27, 2025
@sushi30 sushi30 marked this pull request as draft January 27, 2025 16:22
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 29, 2025 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.51% (41061/63648) 40.74% (16457/40395) 43.99% (4983/11327)

@sushi30 sushi30 marked this pull request as ready for review January 30, 2025 10:15
chirag-madlani
chirag-madlani previously approved these changes Jan 30, 2025
View reviewed changes
@karanh37 karanh37 marked this pull request as draft January 31, 2025 07:37
@karanh37 karanh37 marked this pull request as ready for review January 31, 2025 07:48
@sushi30 sushi30 enabled auto-merge (squash) January 31, 2025 08:45
@karanh37 karanh37 marked this pull request as draft January 31, 2025 14:07
auto-merge was automatically disabled January 31, 2025 14:07

Pull request was converted to draft

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@karanh37 karanh37 marked this pull request as ready for review February 3, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
Release 1.6.4
Status: Platform
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sushi30 @chirag-madlani @karanh37