Skip to content
This repository has been archived by the owner on May 17, 2023. It is now read-only.

Fix helpful.js memory leak #176

Open
wants to merge 1 commit into
base: publish
Choose a base branch
from

Conversation

snehankekre
Copy link

Browsing many (15-30+) pages in succession on the same browser tab causes the tab to slow down and eventually crash due to a memory leak in the helpful.js component.

Screenshot 2023-02-06 at 16 35 42

That component is called every time one changes the page. Over time, it stacks so many function calls that it breaks the site. The solution is to perform the route change cleanup function for the Helpful component inside a useEffect call instead of using router.events.on("routeChangeComplete", handleRouteChange).

@netlify
Copy link

netlify bot commented Feb 6, 2023

Deploy Preview for openmetadata-docs ready!

Name Link
🔨 Latest commit 54a462c
🔍 Latest deploy log https://app.netlify.com/sites/openmetadata-docs/deploys/63e0e7409cbd7b0008cbb1e5
😎 Deploy Preview https://deploy-preview-176--openmetadata-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant