Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TransformerVC implementation #90

Closed
wants to merge 10 commits into from
Closed

Conversation

ArkhamImp
Copy link
Collaborator

The code has been tested, and the model is under training.

@lmxue
Copy link
Collaborator

lmxue commented Jan 5, 2024

Thanks for your efforts. There are some suggestions for a standard PR, especially for the PR that integrates a new model into Amphion:

  • Please format the code using black
  • Please detail PR descriptions, including the PR purpose, supported model, etc.
  • Please attach the pre-trained models as well as some samples in this PR.
  • Please submit a PR from a specific branch instead of the main branch.

@jiaqili3 jiaqili3 requested a review from lmxue January 6, 2024 02:04
@RMSnow
Copy link
Collaborator

RMSnow commented Jan 6, 2024

Thanks @ArkhamImp a lot to integrate our first VC model. For the "New Feature" PR, the review stage is more strict and usually takes several request-change loops.

You can follow these two PRs to provide the inference samples of TransformerVC, so that we can ensure the code is bug-free:

  1. DiffWave Vocoder Added #56
  2. Add VitsSVC implementation #14

A perfect "New Feature" PR will contain:

  • (1) Code;
  • (2) Generated Samples;
  • (3) Recipe and Doc;
  • (4) Pretrained Models in our Huggingface;
  • (5) Gradio Demo in our Huggingface.

I think for this PR, you need to provide (1)-(2) at least. Besides, you can schedule an expected date for (3) to inform others. After (1)-(3), we can assign other developers to cooperate with you to accomplish (4) and (5).

@ArkhamImp
Copy link
Collaborator Author

Voice Conversion Samples

Sample 1

Source

121_121726_000020_000001.mp4

Target

672_122797_000002_000002.mp4

Converted

121_121726_000020_000001_672_122797_000002_000002.mp4

Sample 2

Source

1089_134686_000018_000000.mp4

Target

lj001-0003.mp4

Converted

1089_134686_000018_000000_LJ001-0003.mp4

@ArkhamImp
Copy link
Collaborator Author

@RMSnow RMSnow self-requested a review January 27, 2024 02:08
Copy link
Collaborator

@RMSnow RMSnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ArkhamImp ! The VitsVC samples sound better than TransformerVC. You can integrate the both two if you are ready!

@ArkhamImp
Copy link
Collaborator Author

Ready to integrate.

@ArkhamImp ArkhamImp requested a review from RMSnow January 29, 2024 01:18
@RMSnow RMSnow requested a review from Adorable-Qin January 29, 2024 03:51
@ArkhamImp ArkhamImp deleted the branch open-mmlab:main April 17, 2024 01:41
@ArkhamImp ArkhamImp closed this Apr 17, 2024
@ArkhamImp ArkhamImp deleted the main branch April 17, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants