-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TransformerVC implementation #90
Conversation
Thanks for your efforts. There are some suggestions for a standard PR, especially for the PR that integrates a new model into Amphion:
|
Thanks @ArkhamImp a lot to integrate our first VC model. For the "New Feature" PR, the review stage is more strict and usually takes several request-change loops. You can follow these two PRs to provide the inference samples of TransformerVC, so that we can ensure the code is bug-free: A perfect "New Feature" PR will contain:
I think for this PR, you need to provide (1)-(2) at least. Besides, you can schedule an expected date for (3) to inform others. After (1)-(3), we can assign other developers to cooperate with you to accomplish (4) and (5). |
Voice Conversion SamplesSample 1Source121_121726_000020_000001.mp4Target672_122797_000002_000002.mp4Converted121_121726_000020_000001_672_122797_000002_000002.mp4Sample 2Source1089_134686_000018_000000.mp4Targetlj001-0003.mp4Converted1089_134686_000018_000000_LJ001-0003.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ArkhamImp ! The VitsVC samples sound better than TransformerVC. You can integrate the both two if you are ready!
Ready to integrate. |
The code has been tested, and the model is under training.