Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why do not provide the Runner Constructor #1225

Closed
densechen opened this issue Jul 29, 2021 · 9 comments
Closed

Why do not provide the Runner Constructor #1225

densechen opened this issue Jul 29, 2021 · 9 comments
Assignees

Comments

@densechen
Copy link
Contributor

densechen commented Jul 29, 2021

There are OptimizerConstructor ..., but why not provide a runner constructor?
It would be more general and flexible to implement some functions.
Looking forward it.

@zhouzaida
Copy link
Collaborator

hi @densechen , Thanks for your feedback. Could you give an example of what functions do you want to implement

@densechen
Copy link
Contributor Author

Hi, @zhouzaida, if a RunnerConstructor is provided, we can have the ability to make some extra operations on the build runner without the necessary to change the user code.
By the way, we have developed a new open source pytorch-style federated learning library, which will be released soon.
We are currently palning to write an extra package that constumed for mm-xxx project. It will make all the mm-xxx project enable to do federated learning experiments without the necessary to change the user code, but just import our extra package at the beginning of code.
While developing this extra package, we found that it may be more flexible to provide a RunnerConstructor in our case.

@zhouzaida
Copy link
Collaborator

@ZwwWayne , please have a look

@densechen
Copy link
Contributor Author

Any update?

@zhouzaida
Copy link
Collaborator

zhouzaida commented Aug 2, 2021

yet, That sounds so good. And are you willing to create a PR?

@ZwwWayne
Copy link
Collaborator

ZwwWayne commented Aug 2, 2021

Hi @densechen
Thanks for your kind suggestion. We do not do that before just because we have not considered it:). We are indeed considering making runners more flexible. For now, we think RunnerConstructor might be a good suggestion but we need to consider it further because it is actually a big change and needs a complete design. Therefore, it might take some time before we make the decision and make it.

@densechen
Copy link
Contributor Author

@ZwwWayne @zhouzaida Thanks for your replies. And I will create a PR as soon as possible and also make sure that minor modification is needed.

@zhouzaida
Copy link
Collaborator

Looking forward to your PR

@zhouzaida
Copy link
Collaborator

closed by #1296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants