Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RunnerConstructor #1296

Merged
merged 12 commits into from
Aug 24, 2021
Merged

RunnerConstructor #1296

merged 12 commits into from
Aug 24, 2021

Conversation

densechen
Copy link
Contributor

@densechen densechen commented Aug 23, 2021

Motivation

Refer to #1238

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@densechen densechen mentioned this pull request Aug 23, 2021
@zhouzaida zhouzaida mentioned this pull request Aug 23, 2021
13 tasks
@codecov
Copy link

codecov bot commented Aug 23, 2021

Codecov Report

Merging #1296 (785e6d9) into master (ea3e978) will increase coverage by 0.03%.
The diff coverage is 90.00%.

❗ Current head 785e6d9 differs from pull request most recent head 266685d. Consider uploading reports for the commit 266685d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1296      +/-   ##
==========================================
+ Coverage   68.23%   68.26%   +0.03%     
==========================================
  Files         160      161       +1     
  Lines       10722    10740      +18     
  Branches     1969     1971       +2     
==========================================
+ Hits         7316     7332      +16     
- Misses       3022     3023       +1     
- Partials      384      385       +1     
Flag Coverage Δ
unittests 68.26% <90.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcv/runner/default_constructor.py 77.77% <77.77%> (ø)
mmcv/runner/__init__.py 100.00% <100.00%> (ø)
mmcv/runner/builder.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea3e978...266685d. Read the comment docs.

Copy link
Collaborator

@zhouzaida zhouzaida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZwwWayne ZwwWayne merged commit 642b48f into open-mmlab:master Aug 24, 2021
@OpenMMLab-Coodinator
Copy link

Hi @densechen !First of all, we want to express our gratitude for your significant PR in this project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/raweFPmdzG

If you are Chinese or have WeChat,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants