Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] LR triangular #1001

Merged
merged 8 commits into from
May 11, 2021
Merged

Conversation

gengenkai
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Add a linear triangular learning rate strategy.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #1001 (9d8709c) into master (934b549) will increase coverage by 0.03%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1001      +/-   ##
==========================================
+ Coverage   64.56%   64.59%   +0.03%     
==========================================
  Files         152      152              
  Lines        9800     9806       +6     
  Branches     1780     1783       +3     
==========================================
+ Hits         6327     6334       +7     
+ Misses       3144     3143       -1     
  Partials      329      329              
Flag Coverage Δ
unittests 64.59% <85.71%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcv/runner/hooks/lr_updater.py 69.42% <85.71%> (+0.27%) ⬆️
mmcv/runner/iter_based_runner.py 56.83% <0.00%> (+0.71%) ⬆️
mmcv/runner/hooks/logger/pavi.py 70.58% <0.00%> (+1.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 934b549...9d8709c. Read the comment docs.

@zhouzaida
Copy link
Collaborator

please add unittest

@ZwwWayne ZwwWayne mentioned this pull request May 1, 2021
13 tasks
@ZwwWayne
Copy link
Collaborator

@gengenkai need to resolve conflicts before merge.

@zhouzaida zhouzaida changed the title Lr triangular [Enhancement] LR triangular May 11, 2021
@ZwwWayne ZwwWayne merged commit 1a5bf76 into open-mmlab:master May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants