Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix pybind exporting bug in fused_bias_leakyrelu and upfirdn2d #1005

Merged
merged 2 commits into from
Apr 29, 2021

Conversation

luopeichao
Copy link
Contributor

We find a pybind exporting bug in fused_bias_leakyrelu and upfirdn2d sothat these operators cannot be used in pytorch. This PR can fix it.
By the way, we fix a minor bug in roi_pool which will cause compiling error when using parrots-nocuda.

@zhouzaida zhouzaida requested a review from nbei April 29, 2021 09:43
@ZwwWayne ZwwWayne merged commit 3c7321c into open-mmlab:master Apr 29, 2021
@luopeichao luopeichao deleted the pc/fix_fused_bias_leakyrelu branch January 11, 2022 07:52
@OpenMMLab-Assistant-004
Copy link

Hi @luopeichao !First of all, we want to express our gratitude for your significant PR in the mmcv project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/raweFPmdzG

If you have WeChat,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants