-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Fix SyncBN build in PyTorch 1.9 #1138
Conversation
We may need CI for PyTorch 1.9. @zhouzaida |
yet, we are resolving the compatibility in PyTorch1.9 |
Codecov Report
@@ Coverage Diff @@
## master #1138 +/- ##
=======================================
Coverage 67.96% 67.96%
=======================================
Files 159 159
Lines 10419 10416 -3
Branches 1897 1896 -1
=======================================
- Hits 7081 7079 -2
Misses 2969 2969
+ Partials 369 368 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Seems this PR does not totally fix #1137 here : mmcv/mmcv/utils/parrots_wrapper.py Lines 83 to 87 in eb08835
|
We should check why pytorch1.9 removes the function, please refer to Remove _specify_ddp_gpu_num method |
They remove it because it's not useful any more. The attribute |
Motivation
Fix #1137
Modification
Check whether attribute
_specify_ddp_gpu_num
exists.BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
No