Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add ONNX export support to torch.roll #1194

Merged
merged 5 commits into from
Jul 20, 2021

Conversation

grimoire
Copy link
Member

Motivation

This PR add ONNX export support to torch.roll.
Related to open-mmlab/mmsegmentation#693 (comment)

Modification

Add torch.roll symbolic file and related onnx test.

@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #1194 (8974a71) into master (db580dd) will increase coverage by 0.09%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1194      +/-   ##
==========================================
+ Coverage   67.99%   68.08%   +0.09%     
==========================================
  Files         159      160       +1     
  Lines       10426    10472      +46     
  Branches     1897     1906       +9     
==========================================
+ Hits         7089     7130      +41     
  Misses       2968     2968              
- Partials      369      374       +5     
Flag Coverage Δ
unittests 68.08% <86.66%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcv/onnx/symbolic.py 53.44% <86.66%> (+5.17%) ⬆️
mmcv/utils/parrots_wrapper.py 59.37% <0.00%> (-1.34%) ⬇️
mmcv/utils/trace.py 54.54% <0.00%> (ø)
mmcv/image/photometric.py 99.27% <0.00%> (+<0.01%) ⬆️
mmcv/utils/__init__.py 88.88% <0.00%> (+0.65%) ⬆️
mmcv/ops/cc_attention.py 38.70% <0.00%> (+1.00%) ⬆️
mmcv/onnx/onnx_utils/symbolic_helper.py 40.69% <0.00%> (+1.16%) ⬆️
mmcv/runner/iter_based_runner.py 60.00% <0.00%> (+2.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db580dd...8974a71. Read the comment docs.

Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the comments are resolved.

@RunningLeon
Copy link
Collaborator

Kindly ping@ZwwWayne

@ZwwWayne ZwwWayne merged commit 5f9e6b6 into open-mmlab:master Jul 20, 2021
@grimoire grimoire deleted the onnx_roll branch September 15, 2021 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants