-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] Refactor the directory of csrc #1206
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1206 +/- ##
=======================================
Coverage 68.28% 68.28%
=======================================
Files 160 160
Lines 10603 10603
Branches 1937 1937
=======================================
Hits 7240 7240
Misses 2979 2979
Partials 384 384
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
I suggest we start to maintain compatibility documentation as in https://mmdetection.readthedocs.io/en/latest/compatibility.html to record these refactoring changes. Though they do not affect the usage in API. |
OK |
[DOC] Add csrc readme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we rename HIP_DIFF
to MMCV_WITH_HIP
, just like other mmcv flag?
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Refactor the directory
mmcv/ops/csrc
to flexibly support more backends.Follow commands have been successfully tested
Modification
mmcv/ops/csrc
andsetup.py
are modifiedmmcv/ops/csrc/README.md
is added for explaining the structure of csrc and how to add new opsdocs/compatibility.md
anddocs_zh_CN/compatibility.md
are added for recording compatibilityBC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist