Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] fix train example #1502

Merged
merged 4 commits into from
Nov 23, 2021
Merged

Conversation

teamwong111
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Related issue: #1470.
Some users want to test the example/train.py on single GPU even though there are multiple GPUs on their machines.
Force to use GPU:0 can avoid Error traceback.

Modification

Assign device_ids = [0] and fix a format error by the way.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@zhouzaida
Copy link
Collaborator

Please add the following warning information in the docstring.

mmcv/parallel/data_parallel.py

.. warning::
    MMDataParallel only supports single GPU training, if you need to train with multiple GPUs, please use MMDistributedDataParallel instead. If you have multiple GPUs and you just want to use MMDataParallel, you can set the ``CUDA_VISIBLE_DEVICES=0`` or ``MMDataParallel(model, device_ids=[0])``.

examples/train.py Outdated Show resolved Hide resolved
@ZwwWayne ZwwWayne merged commit b57825f into open-mmlab:master Nov 23, 2021
@teamwong111 teamwong111 deleted the fix-train-example branch November 24, 2021 08:21
zhouzaida pushed a commit that referenced this pull request Nov 27, 2021
* [Fix] fix train example

* [Fix] fix a detail in train example and add warning in MMDP

* [Fix] fix docstring

* [Fix] fix docstring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants