-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add ModuleDict inherited from BaseModule and ModuleDict #1542
Conversation
Hi @LutingWang , thanks for your contribution. You can merge the master branch to your branch because the circleci of CI depends on a file In addition, the unit tests should be added and you can refer to mmcv/tests/test_runner/test_basemodule.py Line 523 in 0086bef
|
The lint (https://app.circleci.com/pipelines/github/open-mmlab/mmcv/88/workflows/1b121e11-9403-4266-8ffc-ef11b12f257b/jobs/172) failed. |
41a831f
to
ffbf42c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mmcv/runner/base_module.py
Outdated
"""ModuleDict in openmmlab. | ||
|
||
Args: | ||
modules (dict, optional): an dict of modules to add. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modules(dict, optional): A mapping (dictionary) of (string: module) or an iterable of key-value pairs of type (string, module)
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Add ModuleDict base module.
Modification
mmcv/runner/init.py
mmcv/runner/base_module.py
docs/understand_mmcv/cnn.md
docs_zh_CN/understand_mmcv/cnn.md
mmcv/tests/test_runner/test_basemodule.py
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist
Before PR:
After PR: