-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add artifact logging to wandb hook #1616
Conversation
Hi @fcakyon, Should we provide an option to upload only the specified file suffix like mmcv/runner/hooks/logger/text.py , since some files are too large and not always needed. |
@zhouzaida its done! |
👍 |
It would be great if some unit tests are added. |
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
its also done 👍 |
Wow, it is so great. |
@zhouzaida it is ready 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that the docstring lacks an args with_step
.
@teamwong111 i have no idea what |
The details about the argument can be found at #913 |
@zhouzaida it is ready to be merged now 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you for your contribution
@zhouzaida @teamwong111 when will this be merged? i need it urgently :) |
Hi @fcakyon , we will merge the PR in the next few days. |
Problem: Currently it is not possible to upload experiment config files and model weights to wandb. However it very crucial to properly track experiments.
Solution: With this PR, users can upload the contents in
work_dir
to wandb after training ends utilizinglog_artifact()
method of wandb logger: https://docs.wandb.ai/ref/python/run#log_artifactUsage: