Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove many functions in utils #2217

Merged
merged 6 commits into from
Aug 23, 2022
Merged

Remove many functions in utils #2217

merged 6 commits into from
Aug 23, 2022

Conversation

zhouzaida
Copy link
Collaborator

@zhouzaida zhouzaida commented Aug 20, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Migrate many functions from mmcv to mmengine (open-mmlab/mmengine#447)

Downstream repos can refer to open-mmlab/mmocr#1295 to refactor repos.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@zhouzaida zhouzaida changed the base branch from zzd/remove-runner to dev-2.x August 22, 2022 11:22
@zhouzaida zhouzaida changed the base branch from dev-2.x to zzd/remove-runner August 22, 2022 11:22
@zhouzaida zhouzaida changed the base branch from zzd/remove-runner to dev-2.x August 22, 2022 14:27
@zhouzaida zhouzaida changed the title [WIP] Remove many functions in utils Remove many functions in utils Aug 22, 2022
@zhouzaida zhouzaida merged commit 5947178 into dev-2.x Aug 23, 2022
@zhouzaida zhouzaida deleted the zzd/remove-utils branch August 23, 2022 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants