Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] cast the type of mask to enable training with amp #2220

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

zengyh1900
Copy link
Collaborator

@zengyh1900 zengyh1900 commented Aug 22, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Fix the bug in ModulatedDeformConv2dFunction to enable training with AMP.

The snippet of the error message is as below:

"/mnt/cache/xxx/mmediting/mmedit/models/editors/basicvsr_plusplus_net/basicvsr_plusplus_net.py", line 413, in forward
    return modulated_deform_conv2d(x, offset, mask, self.weight, self.bias,
  File "/mnt/cache/zengyanhong/mmcv/mmcv/ops/modulated_deform_conv.py", line 76, in forward
    ext_module.modulated_deform_conv_forward(
RuntimeError: expected scalar type Float but found Half

torch: 1.8.0+cu111

Modification

cast the type of mask the same as input in ModulatedDeformConv2dFunction.

BC-breaking (Optional)

No

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@CLAassistant
Copy link

CLAassistant commented Aug 22, 2022

CLA assistant check
All committers have signed the CLA.

@zhouzaida zhouzaida merged commit 961373a into dev-2.x Aug 24, 2022
@zhouzaida zhouzaida deleted the fix-modulated_deform_conv2d_function branch August 24, 2022 12:28
zhouzaida pushed a commit to zhouzaida/mmcv that referenced this pull request Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants