Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of TorchVision's Model Registration API on MMCV #2246

Merged
merged 3 commits into from
Sep 14, 2022

Conversation

datumbox
Copy link

@datumbox datumbox commented Sep 6, 2022

Hi OpenMMLab team,

First of all thank you very much for developing your awesome framework.

TorchVision has recently introduced a new Model Registration API which allows the easier listing of models and weights. Its aim is to eliminate the somehow hacky idiom of using torchvision.models.__dict__ to retrieve models and weights.

In this PR, I'm updating your existing implementation introduced at #1848 to use our new API. Please note that I'm going for the minimum number of modifications necessary; the code may be further simplified but that might require additional discussion.

For full transparency, the new API is currently considered Beta. We've intentionally marked it as such to ensure that we can act upon the feedback of our partners and users. We are currently collecting feedback at pytorch/vision#6365 and hoping to promote to stable before TorchVision v0.14. If you have any feedback or feature requests, we would be happy to discuss more. Finally, please note that if we end up making breaking changes on the API after you merge this PR, we will make sure to follow up with all the necessary fixes to keep the Open-MMLab users unaffected.

Looking forward to your feedback.

@CLAassistant
Copy link

CLAassistant commented Sep 6, 2022

CLA assistant check
All committers have signed the CLA.

@zhouzaida zhouzaida requested a review from HAOCHENYE September 7, 2022 05:30
@zhouzaida
Copy link
Collaborator

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @datumbox , thanks to the TorchVision team for keeping us informed of new changes. Totally agree with the Model Registration API to make it easier to get models and weights. After signing the CLA, we can merge this PR.

@datumbox
Copy link
Author

datumbox commented Sep 8, 2022

@zhouzaida Thank you very much for the prompt review. I really appreciate it.

I've raised a request to my company to approve my signing of the CLAs. It's likely to take a week but I don't believe this is going to be an issue. I opted for going through the whole approval process to be able to make more contributions to your project on the future if necessary. :)

I'll ping you once I get the approval and sign the CLAs.

@zhouzaida
Copy link
Collaborator

@zhouzaida Thank you very much for the prompt review. I really appreciate it.

I've raised a request to my company to approve my signing of the CLAs. It's likely to take a week but I don't believe this is going to be an issue. I opted for going through the whole approval process to be able to make more contributions to your project on the future if necessary. :)

I'll ping you once I get the approval and sign the CLAs.

Okay, looking forward to our more cooperation.

@datumbox
Copy link
Author

@zhouzaida I got permission to sign the CLAs. We should be good to go :)

Let me know if you need anything else from my side. Thanks!

@zhouzaida zhouzaida merged commit 3b9b905 into open-mmlab:master Sep 14, 2022
@datumbox datumbox deleted the tv_model_reg_api branch September 14, 2022 11:29
@OpenMMLab-Assistant005
Copy link

Hi @datumbox !First of all, we want to express our gratitude for your significant PR in the MMCV project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA

If you have WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants