-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Support RoipointPool3d with cambricon MLU backend #2247
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ab#2247) * [Feature] Support RoipointPool3d with cambricon MLU backend * [Feature] Support RoipointPool3d with cambricon MLU backend * [Feature] Support RoipointPool3d with cambricon MLU backend * [Feature] Support RoipointPool3d with cambricon MLU backend * [Feature] Support RoipointPool3d with cambricon MLU backend
…ab#2247) * [Feature] Support RoipointPool3d with cambricon MLU backend * [Feature] Support RoipointPool3d with cambricon MLU backend * [Feature] Support RoipointPool3d with cambricon MLU backend * [Feature] Support RoipointPool3d with cambricon MLU backend * [Feature] Support RoipointPool3d with cambricon MLU backend
* [Feature] Support RoipointPool3d with cambricon MLU backend * [Feature] Support RoipointPool3d with cambricon MLU backend * [Feature] Support RoipointPool3d with cambricon MLU backend * [Feature] Support RoipointPool3d with cambricon MLU backend * [Feature] Support RoipointPool3d with cambricon MLU backend
Hi @ZShaopeng !First of all, we want to express our gratitude for your significant PR in the MMCV project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR. We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA If you have WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:) |
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
The motivation of the PR is to support running RoipointPool3d with Cambricon MLU backend.
It includes three parts:
Modification
Add MLU src code of RoipointPool3d in directory mmcv/ops/csrc/common/mlu/roipoint_pool3d_mlu_kernel.mlu.
Add MLU src code of RoipointPool3d in directory mmcv/ops/csrc/common/mlu/roipoint_pool3d_large_boxes_num_mlu_kernel.mlu.
Adapt RoipointPool3d for PyTorch in mmcv/ops/csrc/pytorch/mlu/roipoint_pool3d_mlu.cpp.
Support test RoipointPool3d with various backends in tests/test_ops/test_roipoint_pool3d.py.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist
Before PR:
After PR: