Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support RoipointPool3d with cambricon MLU backend #2247

Merged
merged 5 commits into from
Sep 8, 2022
Merged

[Feature] Support RoipointPool3d with cambricon MLU backend #2247

merged 5 commits into from
Sep 8, 2022

Conversation

ZShaopeng
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

The motivation of the PR is to support running RoipointPool3d with Cambricon MLU backend.

It includes three parts:

1. Add roipoint_pool3d_mlu_kernel.mlu and roipoint_pool3d_large_boxes_num_mlu_kernel.mlu src code as MLU kernel.
2. Add roipoint_pool3d_mlu.cpp to support launching kernel in PyTorch.
3. Refactor test_roipoint_pool3d.py to support testing RoipointPool3d with MLU backend.

Modification

  • MLU src code
    Add MLU src code of RoipointPool3d in directory mmcv/ops/csrc/common/mlu/roipoint_pool3d_mlu_kernel.mlu.
    Add MLU src code of RoipointPool3d in directory mmcv/ops/csrc/common/mlu/roipoint_pool3d_large_boxes_num_mlu_kernel.mlu.
  • PyTorch adaptation
    Adapt RoipointPool3d for PyTorch in mmcv/ops/csrc/pytorch/mlu/roipoint_pool3d_mlu.cpp.
  • Unit test
    Support test RoipointPool3d with various backends in tests/test_ops/test_roipoint_pool3d.py.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@ZShaopeng ZShaopeng changed the title Roipoint pool3d [Feature] Support RoipointPool3d with cambricon MLU backend Sep 7, 2022
@zhouzaida zhouzaida added the MLU label Sep 7, 2022
Copy link
Member

@grimoire grimoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouzaida zhouzaida merged commit 83bedf5 into open-mmlab:master Sep 8, 2022
zhouzaida pushed a commit to zhouzaida/mmcv that referenced this pull request Oct 20, 2022
…ab#2247)

* [Feature] Support RoipointPool3d with cambricon MLU backend

* [Feature] Support RoipointPool3d with cambricon MLU backend

* [Feature] Support RoipointPool3d with cambricon MLU backend

* [Feature] Support RoipointPool3d with cambricon MLU backend

* [Feature] Support RoipointPool3d with cambricon MLU backend
zhouzaida pushed a commit to zhouzaida/mmcv that referenced this pull request Oct 22, 2022
…ab#2247)

* [Feature] Support RoipointPool3d with cambricon MLU backend

* [Feature] Support RoipointPool3d with cambricon MLU backend

* [Feature] Support RoipointPool3d with cambricon MLU backend

* [Feature] Support RoipointPool3d with cambricon MLU backend

* [Feature] Support RoipointPool3d with cambricon MLU backend
zhouzaida pushed a commit that referenced this pull request Oct 22, 2022
* [Feature] Support RoipointPool3d with cambricon MLU backend

* [Feature] Support RoipointPool3d with cambricon MLU backend

* [Feature] Support RoipointPool3d with cambricon MLU backend

* [Feature] Support RoipointPool3d with cambricon MLU backend

* [Feature] Support RoipointPool3d with cambricon MLU backend
@ZShaopeng ZShaopeng deleted the roipoint_pool3d branch February 9, 2023 03:13
@OpenMMLab-Assistant001
Copy link

Hi @ZShaopeng !First of all, we want to express our gratitude for your significant PR in the MMCV project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA

If you have WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution!❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants