[Fix] Fix the calculation error of out_w in MaskedConv2dFunction #2264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouzaida
changed the title
zhouzaida
added a commit
to zhouzaida/mmcv
that referenced
this pull request
Sep 25, 2022
…n-mmlab#2264) * [Fix] Fix two intergers can not use / operator in torch1.6 * should not use kernel_h when calculates out_w
zhouzaida
added a commit
that referenced
this pull request
Sep 25, 2022
* [Fix] Fix the calculation error of out_w in MaskedConv2dFunction (#2264) * [Fix] Fix two intergers can not use / operator in torch1.6 * should not use kernel_h when calculates out_w * [Docs] Fix some mistakes in data_process.md (#2283) * correction * correction en docs Co-authored-by: yxzhao <33384732+yxzhao2022@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Fix the calculation error of out_w in MaskedConv2dFunction and this function can not work in torch1.6 due to / operator. More details at https://app.circleci.com/pipelines/github/open-mmlab/mmcv/1574/workflows/3056e22f-a35d-4a55-995f-e66f3acdcc23/jobs/3077?invite=true#step-107-177.
Modification
mmcv/ops/masked_conv.py
BC-breaking (Optional)
No
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist
Before PR:
After PR: