Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add box_iou_quadri & nms_quadri #2277

Merged
merged 17 commits into from
Oct 13, 2022

Conversation

zytx121
Copy link
Contributor

@zytx121 zytx121 commented Sep 21, 2022

Motivation

Add box_iou_quadri and nms_quadri ops, which used by quadrilateral boxes detection in open-mmlab/mmrotate#520

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Base: 65.53% // Head: 65.66% // Increases project coverage by +0.13% 🎉

Coverage data is based on head (dd759bc) compared to base (936c193).
Patch coverage: 93.75% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #2277      +/-   ##
==========================================
+ Coverage   65.53%   65.66%   +0.13%     
==========================================
  Files         122      123       +1     
  Lines        8107     8138      +31     
  Branches     1229     1112     -117     
==========================================
+ Hits         5313     5344      +31     
  Misses       2613     2613              
  Partials      181      181              
Flag Coverage Δ
unittests 65.66% <93.75%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcv/ops/nms.py 62.98% <83.33%> (+2.62%) ⬆️
mmcv/ops/__init__.py 100.00% <100.00%> (ø)
mmcv/ops/box_iou_quadri.py 100.00% <100.00%> (ø)
mmcv/ops/iou3d.py 20.28% <0.00%> (ø)
mmcv/image/geometric.py 94.04% <0.00%> (ø)
mmcv/transforms/base.py 100.00% <0.00%> (ø)
mmcv/transforms/loading.py 100.00% <0.00%> (ø)
mmcv/transforms/processing.py 95.11% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zytx121 zytx121 changed the title [Feature] Add box_iou_quadri [Feature] Add box_iou_quadri & nms_quadri Sep 21, 2022
Copy link
Member

@grimoire grimoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmcv/ops/nms.py Outdated Show resolved Hide resolved
zytx121 and others added 3 commits October 12, 2022 23:09
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
@zhouzaida zhouzaida merged commit a4c8261 into open-mmlab:2.x Oct 13, 2022
zhouzaida pushed a commit to zhouzaida/mmcv that referenced this pull request Oct 28, 2022
* update

* update

* fix link

* fix bug

* update nms_quadri

* fix lint

* Update test_nms_quadri.py

* Update box_iou_quadri.py

* fix bug

* Update test_nms_quadri.py

* Update box_iou_rotated_utils.hpp

* Update box_iou_quadri.py

* Update mmcv/ops/nms.py
zhouzaida pushed a commit that referenced this pull request Oct 28, 2022
* update

* update

* fix link

* fix bug

* update nms_quadri

* fix lint

* Update test_nms_quadri.py

* Update box_iou_quadri.py

* fix bug

* Update test_nms_quadri.py

* Update box_iou_rotated_utils.hpp

* Update box_iou_quadri.py

* Update mmcv/ops/nms.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants