-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add box_iou_quadri & nms_quadri #2277
Conversation
Codecov ReportBase: 65.53% // Head: 65.66% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## 2.x #2277 +/- ##
==========================================
+ Coverage 65.53% 65.66% +0.13%
==========================================
Files 122 123 +1
Lines 8107 8138 +31
Branches 1229 1112 -117
==========================================
+ Hits 5313 5344 +31
Misses 2613 2613
Partials 181 181
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
* update * update * fix link * fix bug * update nms_quadri * fix lint * Update test_nms_quadri.py * Update box_iou_quadri.py * fix bug * Update test_nms_quadri.py * Update box_iou_rotated_utils.hpp * Update box_iou_quadri.py * Update mmcv/ops/nms.py
* update * update * fix link * fix bug * update nms_quadri * fix lint * Update test_nms_quadri.py * Update box_iou_quadri.py * fix bug * Update test_nms_quadri.py * Update box_iou_rotated_utils.hpp * Update box_iou_quadri.py * Update mmcv/ops/nms.py
Motivation
Add
box_iou_quadri
andnms_quadri
ops, which used by quadrilateral boxes detection in open-mmlab/mmrotate#520Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist
Before PR:
After PR: