Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Features] Add stack ball query and stack group points ops #2292

Merged
merged 13 commits into from
Oct 27, 2022

Conversation

VVsssssk
Copy link
Contributor

@VVsssssk VVsssssk commented Sep 27, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Add stack ball query ops and stack group points to support Stack SA module in mmdet3d.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

Copy link
Member

@grimoire grimoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VVsssssk VVsssssk changed the title [Features]Add stack ball query ops [Features]Add stack ball query and stack group points ops Oct 11, 2022
@grimoire
Copy link
Member

Fix lint.

@VVsssssk VVsssssk changed the base branch from master to 2.x October 14, 2022 07:24
mmcv/ops/group_points.py Outdated Show resolved Hide resolved
mmcv/ops/group_points.py Outdated Show resolved Hide resolved
mmcv/ops/ball_query.py Outdated Show resolved Hide resolved
mmcv/ops/group_points.py Outdated Show resolved Hide resolved
mmcv/ops/group_points.py Outdated Show resolved Hide resolved
mmcv/ops/group_points.py Outdated Show resolved Hide resolved
@zhouzaida zhouzaida changed the title [Features]Add stack ball query and stack group points ops [Features] Add stack ball query and stack group points ops Oct 25, 2022
@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Base: 66.78% // Head: 66.60% // Decreases project coverage by -0.17% ⚠️

Coverage data is based on head (59ab323) compared to base (2b97c52).
Patch coverage: 14.28% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #2292      +/-   ##
==========================================
- Coverage   66.78%   66.60%   -0.18%     
==========================================
  Files         120      120              
  Lines        7779     7800      +21     
  Branches     1064     1067       +3     
==========================================
  Hits         5195     5195              
- Misses       2417     2438      +21     
  Partials      167      167              
Flag Coverage Δ
unittests 66.60% <14.28%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcv/ops/group_points.py 18.18% <10.00%> (-3.10%) ⬇️
mmcv/ops/ball_query.py 40.74% <25.00%> (-9.26%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

mmcv/ops/group_points.py Outdated Show resolved Hide resolved
@zhouzaida zhouzaida merged commit 4e0341f into open-mmlab:2.x Oct 27, 2022
zhouzaida pushed a commit to zhouzaida/mmcv that referenced this pull request Oct 28, 2022
…b#2292)

* add stack sa model ops

* fix lint

* fix lint

* fix comments

* fix bug

* fix lint

* fix comments

* fix lint

* fix lint

* fix
zhouzaida pushed a commit that referenced this pull request Oct 28, 2022
* add stack sa model ops

* fix lint

* fix lint

* fix comments

* fix bug

* fix lint

* fix comments

* fix lint

* fix lint

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants