-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Features] Add stack ball query and stack group points ops #2292
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix lint. |
07b938f
to
f218a98
Compare
Codecov ReportBase: 66.78% // Head: 66.60% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## 2.x #2292 +/- ##
==========================================
- Coverage 66.78% 66.60% -0.18%
==========================================
Files 120 120
Lines 7779 7800 +21
Branches 1064 1067 +3
==========================================
Hits 5195 5195
- Misses 2417 2438 +21
Partials 167 167
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…b#2292) * add stack sa model ops * fix lint * fix lint * fix comments * fix bug * fix lint * fix comments * fix lint * fix lint * fix
* add stack sa model ops * fix lint * fix lint * fix comments * fix bug * fix lint * fix comments * fix lint * fix lint * fix
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Add stack ball query ops and stack group points to support Stack SA module in mmdet3d.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist
Before PR:
After PR: