-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Add ability to pass logger instance to frameworks #2317
[Enhancement] Add ability to pass logger instance to frameworks #2317
Conversation
Traceback (most recent call last):
File "/home/circleci/.cache/pre-commit/repo_1dyxylu/py_env-python3.7/bin/flake8", line 8, in <module>
sys.exit(main())
File "/home/circleci/.cache/pre-commit/repo_1dyxylu/py_env-python3.7/lib/python3.7/site-packages/flake8/main/cli.py", line 22, in main
app.run(argv)
File "/home/circleci/.cache/pre-commit/repo_1dyxylu/py_env-python3.7/lib/python3.7/site-packages/flake8/main/application.py", line 360, in run
self._run(argv)
File "/home/circleci/.cache/pre-commit/repo_1dyxylu/py_env-python3.7/lib/python3.7/site-packages/flake8/main/application.py", line 347, in _run
self.initialize(argv)
File "/home/circleci/.cache/pre-commit/repo_1dyxylu/py_env-python3.7/lib/python3.7/site-packages/flake8/main/application.py", line 328, in initialize
self.find_plugins(config_finder)
File "/home/circleci/.cache/pre-commit/repo_1dyxylu/py_env-python3.7/lib/python3.7/site-packages/flake8/main/application.py", line 153, in find_plugins
self.check_plugins = plugin_manager.Checkers(local_plugins.extension)
File "/home/circleci/.cache/pre-commit/repo_1dyxylu/py_env-python3.7/lib/python3.7/site-packages/flake8/plugins/manager.py", line 357, in __init__
self.namespace, local_plugins=local_plugins
File "/home/circleci/.cache/pre-commit/repo_1dyxylu/py_env-python3.7/lib/python3.7/site-packages/flake8/plugins/manager.py", line 238, in __init__
self._load_entrypoint_plugins()
File "/home/circleci/.cache/pre-commit/repo_1dyxylu/py_env-python3.7/lib/python3.7/site-packages/flake8/plugins/manager.py", line 254, in _load_entrypoint_plugins
eps = importlib_metadata.entry_points().get(self.namespace, ())
AttributeError: 'EntryPoints' object has no attribute 'get' |
Hi @shcheklein , The reason flake8 failed is that |
Thanks @zhouzaida ! |
@zhouzaida thanks for the pre-commit and linters update. I've rebased the branch. I think you need to approve CI to run? |
…-mmlab#2317) * Add ability to pass logger instance to frameworks * refine docstring * Update mmcv/runner/hooks/logger/dvclive.py Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
…-mmlab#2317) * Add ability to pass logger instance to frameworks * refine docstring * Update mmcv/runner/hooks/logger/dvclive.py Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
Motivation
Updating the DVCLive hook according the latest changes in the way we use loggers in DVCLive.
Modification
dvclive
instance into the hookChecklist
Before PR:
After PR: