-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]Support Iou3d with cambricon MLU backend #2339
Conversation
1c251ba
to
132fa81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Don't forget to skip test case in test_iou3d.py
.
bd3cf57
to
5a1b6fe
Compare
5a1b6fe
to
478d8f5
Compare
* [Feature] Support Iou3d with cambricon MLU backend * [Feature] add double line * [Feature] add line
* [Feature] Support Iou3d with cambricon MLU backend * [Feature] add double line * [Feature] add line
Dear cathyzhang222, |
* [Feature] Support Iou3d with cambricon MLU backend * [Feature] add double line * [Feature] add line
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
The motivation of the PR is to support running Iou3d with Cambricon MLU backend.
It includes three parts:
Modification
Add MLU src code of Iou3d in directory mmcv/ops/csrc/common/mlu/iou3d_mlu_kernel.mlu.
Adapt Iou3d for PyTorch in mmcv/ops/csrc/pytorch/mlu/iou3d_mlu.cpp.
Support test Iou3d with various backends in tests/test_ops/test_iou3d.py.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist
Before PR:
After PR: