Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]Support Iou3d with cambricon MLU backend #2339

Merged
merged 4 commits into from
Oct 24, 2022

Conversation

cathyzhang222
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

The motivation of the PR is to support running Iou3d with Cambricon MLU backend.

It includes three parts:

1. Add iou3d_mlu_kernel.mlu src code as MLU kernel.
2. Add iou3d_mlu.cpp to support launching kernel in PyTorch.
3. Refactor test_iou3d.py to support testing DeformRoiPool with MLU backend.

Modification

  • MLU src code
    Add MLU src code of Iou3d in directory mmcv/ops/csrc/common/mlu/iou3d_mlu_kernel.mlu.
  • PyTorch adaptation
    Adapt Iou3d for PyTorch in mmcv/ops/csrc/pytorch/mlu/iou3d_mlu.cpp.
  • Unit test
    Support test Iou3d with various backends in tests/test_ops/test_iou3d.py.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@CLAassistant
Copy link

CLAassistant commented Oct 18, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@grimoire grimoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Don't forget to skip test case in test_iou3d.py.

@cathyzhang222 cathyzhang222 force-pushed the iou3d8329 branch 2 times, most recently from bd3cf57 to 5a1b6fe Compare October 20, 2022 13:49
@cathyzhang222 cathyzhang222 changed the title [WIP]Support Iou3d with cambricon MLU backend [Feature]Support Iou3d with cambricon MLU backend Oct 21, 2022
@zhouzaida zhouzaida merged commit 7fd7058 into open-mmlab:master Oct 24, 2022
zhouzaida pushed a commit to zhouzaida/mmcv that referenced this pull request Nov 22, 2022
* [Feature] Support Iou3d with cambricon MLU backend

* [Feature] add double line

* [Feature] add line
zhouzaida pushed a commit that referenced this pull request Nov 23, 2022
* [Feature] Support Iou3d with cambricon MLU backend

* [Feature] add double line

* [Feature] add line
@OpenMMLab-Assistant005
Copy link

Dear cathyzhang222,
First of all, we want to express our gratitude for your significant PR in the MMCV project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.
If you are Chinese or have WeChat,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. We look forward to seeing you there! Join us :https://discord.gg/raweFPmdzG
Thank you again for your contribution❤
Best regards! @cathyzhang222

tyomj pushed a commit to tyomj/mmcv that referenced this pull request May 8, 2023
* [Feature] Support Iou3d with cambricon MLU backend

* [Feature] add double line

* [Feature] add line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants