-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the block size to 1024 during compilation. #2460
Conversation
…size of 512.Change the block size to 1024 during compilation.
…size of 512.Change the block size to 1024 during compilation.
…size of 512.Change the block size to 1024 during compilation.
…size of 512.Change the block size to 1024 during compilation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* The default block size of rocm is 256.The designed kenel has a block size of 512.Change the block size to 1024 during compilation. * The default block size of rocm is 256.The designed kenel has a block size of 512.Change the block size to 1024 during compilation. * The default block size of rocm is 256.The designed kenel has a block size of 512.Change the block size to 1024 during compilation. * The default block size of rocm is 256.The designed kenel has a block size of 512.Change the block size to 1024 during compilation.
Dear xiabo123, |
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
The default block size of rocm is 256.The designed kenel has a block size of 512.Change the block size to 1024 during compilation.
Modification
The default block size of rocm is 256.The designed kenel has a block size of 512.Change the block size to 1024 during compilation.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist
Before PR:
After PR: