-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] Use the new interface of fileio from mmengine #2468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouzaida
changed the title
[Refactor] Use new interface of fileio
[Refactor] Use the new interface of fileio from mmengine
Dec 4, 2022
mzr1996
reviewed
Dec 8, 2022
HAOCHENYE
reviewed
Dec 26, 2022
HAOCHENYE
approved these changes
Dec 27, 2022
7 tasks
Merged
6 tasks
tyomj
pushed a commit
to tyomj/mmcv
that referenced
this pull request
May 8, 2023
…2468) * [Refactor] Use new interface of fileio * update ut * remove file_client_args * add * before backend_args * refine backend_args description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Use the new interface of fileio from MMEngine (open-mmlab/mmengine#533) which requires mmengine>=0.2.0.
Modification
mmengine>=0.2.0
in requirements/runtime.txtbackend_args
and removefile_client_args
BC-breaking (Optional)
Yes. This PR removed the
file_client_args
parameter in several functions or classes.Use cases (Optional)
Before this PR
After this PR
The only difference between
file_client_args
andbackend_args
is that the former may contain a prefix field, because in the previous fileio (mmengine < 0.2.0), there were multiple file backends with the same prefix, so you need to specify the prefix infile_client_args
.Checklist
Before PR:
After PR: