-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add npu adapter for deformableroipool #2481
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grimoire
approved these changes
Dec 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zhouzaida
approved these changes
Dec 12, 2022
jayggh
changed the title
add npu adapter for deformroipool
add npu adapter for deformableroipool
Dec 13, 2022
ckirchhoff2021
pushed a commit
to ckirchhoff2021/mmcv
that referenced
this pull request
Dec 21, 2022
* add npu adapter for deformroipool * cleancode * Update deform_roi_pool.cpp * Update deform_roi_pool.cpp * Update deform_roi_pool.cpp * Update deform_roi_pool.cpp * Update deform_roi_pool.cpp * Update deform_roi_pool.cpp * Update deform_roi_pool.cpp
defei-coder
pushed a commit
to defei-coder/mmcv
that referenced
this pull request
Jan 30, 2023
* add npu adapter for deformroipool * cleancode * Update deform_roi_pool.cpp * Update deform_roi_pool.cpp * Update deform_roi_pool.cpp * Update deform_roi_pool.cpp * Update deform_roi_pool.cpp * Update deform_roi_pool.cpp * Update deform_roi_pool.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
This PR contains a npu-adapter of mmcv ops-deformableroipool. we can run these ops(above) on ascend-npu device by these adapters.
Modification
deform_roi_pool.cpp is added to the PR which is used for deformroipool npu-adaptation, while test_deform_roi_pool.py is modified by the PR.