Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add Ascend support for RoIPool op #2483

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

momo609
Copy link
Collaborator

@momo609 momo609 commented Dec 12, 2022

Motivation

add roi_pool npu op

Modification

add roi_pool npu op

@CLAassistant
Copy link

CLAassistant commented Dec 12, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@ckirchhoff2021 ckirchhoff2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouzaida
Copy link
Collaborator

Please update unit tests for this NPU op.

@zhouzaida zhouzaida added the NPU Ascend label Dec 26, 2022
@momo609 momo609 force-pushed the master branch 6 times, most recently from 920de04 to 1f7d272 Compare January 3, 2023 07:14
Copy link
Member

@grimoire grimoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after update docs in zh_cn

@momo609 momo609 force-pushed the master branch 3 times, most recently from 4d739c4 to b8793f2 Compare January 9, 2023 02:36
@zhouzaida zhouzaida changed the title add roi_pool npu op [Feature] Add support for RoIPool Jan 12, 2023
@zhouzaida zhouzaida changed the title [Feature] Add support for RoIPool [Feature] Add Ascend support for RoIPool op Jan 12, 2023
@zhouzaida zhouzaida merged commit 2810718 into open-mmlab:master Jan 12, 2023
defei-coder pushed a commit to defei-coder/mmcv that referenced this pull request Jan 30, 2023
Co-authored-by: wangxiaoxin_sherie <wangxiaoxin7@huawei.com>
CokeDong pushed a commit to CokeDong/mmcv that referenced this pull request Apr 24, 2023
Co-authored-by: wangxiaoxin_sherie <wangxiaoxin7@huawei.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPU Ascend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants