-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add Ascend support for RoIPool op #2483
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
momo609
force-pushed
the
master
branch
4 times, most recently
from
December 12, 2022 08:38
dbe6ea9
to
a28d47d
Compare
ckirchhoff2021
approved these changes
Dec 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please update unit tests for this NPU op. |
momo609
force-pushed
the
master
branch
6 times, most recently
from
January 3, 2023 07:14
920de04
to
1f7d272
Compare
zhouzaida
reviewed
Jan 5, 2023
grimoire
approved these changes
Jan 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after update docs in zh_cn
momo609
force-pushed
the
master
branch
3 times, most recently
from
January 9, 2023 02:36
4d739c4
to
b8793f2
Compare
zhouzaida
approved these changes
Jan 12, 2023
zhouzaida
changed the title
[Feature] Add support for RoIPool
[Feature] Add Ascend support for RoIPool op
Jan 12, 2023
defei-coder
pushed a commit
to defei-coder/mmcv
that referenced
this pull request
Jan 30, 2023
Co-authored-by: wangxiaoxin_sherie <wangxiaoxin7@huawei.com>
CokeDong
pushed a commit
to CokeDong/mmcv
that referenced
this pull request
Apr 24, 2023
Co-authored-by: wangxiaoxin_sherie <wangxiaoxin7@huawei.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
add roi_pool npu op
Modification
add roi_pool npu op